Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple content types and schemas (via oneOf) according to OpenAPI 3.0 spec #792

Conversation

rhurling
Copy link
Contributor

This PR brings the generator in line with the OpenAPI 3.0 Spec (according to https://swagger.io/docs/specification/describing-responses/) and implements multiple response content types and support for multiple response schemas in a single content type (via oneOf).

Currently missing a Unit test for this behavior (will add this soon).

I couldn't find this specific info anywhere in the documentation so I think there is no change necessary.

As I'm not familiar with Postman I don't know if any change is necessary there.

… and schemas (via oneOf) according to OpenAPI 3.0 spec
@shalvah shalvah marked this pull request as ready for review June 17, 2024 20:26
@shalvah shalvah changed the title WIP rewrite generateEndpointResponsesSpec to allow multiple content types and schemas (via oneOf) according to OpenAPI 3.0 spec Allow multiple content types and schemas (via oneOf) according to OpenAPI 3.0 spec Jun 17, 2024
@shalvah
Copy link
Contributor

shalvah commented Jun 17, 2024

Completed this, added a test. Although I think it only supports multiple schemas.

@shalvah shalvah merged commit bd28127 into knuckleswtf:master Jun 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants